Closed wibeasley closed 8 years ago
Hi @zozlak https://github.com/zozlak, I'm excited about using parameterized queries with R and SQL Server. Thanks for this package.
I saw a place in the |sqlExecute.R| code that /would/ be unprotected from a 0-row data frame if it ever was disconnected from the |if(fetch == FALSE | nrow(data) < 1){| block above. I changed the instances in the Rmd file too. I know that your CSVs have more than 0 rows, but someone who copies them as examples may not have the protections against it.
Also, I added an Rproj file to make it a little easier for some people to build/check with the proper architecture arguments.
Dear Will, thank you for your support. I have added you as the package contributor.
If you have access to Ms SQL Server, maybe you can do some testing for me. I need someone to check the behavior of RODBCext in regards to Ms SQL Server "varchar(max)" data type (see https://github.com/zozlak/RODBCext/issues/4). Can you help me with that?
Best regards, Mateusz Żółtak
Hi @zozlak, I'm excited about using parameterized queries with R and SQL Server. Thanks for this package.
I saw a place in the
sqlExecute.R
code that would be unprotected from a 0-row data frame if it ever was disconnected from theif(fetch == FALSE | nrow(data) < 1){
block above. I changed the instances in the Rmd file too. I know that your CSVs have more than 0 rows, but someone who copies them as examples may not have the protections against it.Also, I added an Rproj file to make it a little easier for some people to build/check with the proper architecture arguments.
References