search

zpao / switchToTabBlacklist

A Firefox extension that allows you to blacklist pages from Firefox 4's switch-to-tab feature.
https://addons.mozilla.org/en-US/firefox/addon/switch-to-tab-blacklist/
4 stars 2 forks source link

preference should be extensions.switchToTabBlacklist.blacklist #5

Open MatrixFrog opened 13 years ago

MatrixFrog commented 13 years ago

Sorry to be nitpicky, but the preference should be extensions.switchToTabBlacklist.blacklist not extension.switchToTabBlacklist.blacklist to be consistent with what other extensions do, and with what is generally recommended by Mozilla.

zpao commented 13 years ago

You're right. Unfortunately my initial reviewer told me it was extension. :/

If you want to get it through full review, prefix the extension preferences with "extension."+current name and provide a UI for managing the blacklist.

Ultimately, I don't give a damn either way so won't go out of my way to fix this. If somebody wants to do it, they have my blessing.