search

zpaulovics / datetimepicker-rails

A date and time picker for Twitter Bootstrap in Rails using Simple Form
MIT License
174 stars 80 forks source link

Use https for the submodule #86

Open esjee opened 8 years ago

esjee commented 8 years ago

Hi,

This PR changes the submodule to be cloned over HTTPS rather than the git protocol. For a read-only case such as this, there doesn't appear to be a disadvantage, while offering a slight security benefit.

I hope you find this PR helpful!

alienxp03 commented 2 years ago

Github recently made changes to disallow git:// protocol from being used. Without this PR, current implementation will break bundle install.

https://github.blog/2021-09-01-improving-git-protocol-security-github/