search

zpelgrims / pota

Polynomial optics to Arnold. Camera shader with high-order aberrations, including bidirectional filter that adaptively samples out-of-focus highlights.
https://www.lentil.xyz
20 stars 5 forks source link

Object subdivisions not working as expected #7

Closed zpelgrims closed 6 years ago

zpelgrims commented 6 years ago

Probably due to a bad raster space estimate, implement camera_ray_reverse function

melMass commented 6 years ago

Was about to say that:

Without Pota

With Pota

zpelgrims commented 6 years ago

As a temporary workaround, setting the adaptive space to "object" from "rasters" avoids this issue. Even with adaptive error at 0. I think this is an arnold core bug, along with me not implementing the ray_reverse camera function.

zpelgrims commented 6 years ago

Accidently closed this issue, should defo be open lol

zpelgrims commented 6 years ago

I've implemented two versions of camera_ray_reverse(), a super-accurate polynomial optics version and a pinhole approximation. Currently we'll be using the pinhole approximation, as it is better suited because there is always a solution. The backtraced polynomial optics may run into vignetting of the rays which is a problem.