Restore SCons build, remove global variables, remove use of deprecated AtParamValue array, c++0x compatibility

zpelgrims / zoic

Extended camera shader for the ever-awesome Arnold Renderer

http://www.zenopelgrims.com/zoic

67 stars 25 forks source link

Restore SCons build, remove global variables, remove use of deprecated AtParamValue array, c++0x compatibility #15

Closed gatgui closed 7 years ago

gatgui commented 7 years ago

Sorry for the lengthy title, but the changes kind were depending on one another so I couldn't split in finer PRs. The main points are:

Restoring SCons build script that has disappeared between version 1.1 and 2.0
Removing dependency to C++11: the code is not really using any of the c++11 killer feature so asking for a C++11 compatible compiler is not really a must
Removing usage of deprecated AtParamValue array
Removing usage of global variables but for 2 constant strings holding you local drive paths. By the way, I'd suggest you use another mean (environment variables for example) instead of hardcoding paths in the source code as it is a rather bad practice

zpelgrims commented 7 years ago

Hey man, thanks for these updates. I will merge this at a later point since I need to find time to look into the code changes you did :)

zpelgrims commented 7 years ago

Quick note - thanks for these changes man. It's incredible to see you read my code and completely understand it in such a short amount of time to make structure changes. It's these kinds of changes that teach me a lot.

Thanks!!

gatgui commented 7 years ago

You're welcome, I'm glad you appreciate it.

To be honest, it is not that hard to come up with once you've spent a fair amount of time reading others' code. I do that a lot when the amount of code is not too overwhelming. Helps with debugging too when you use it in prod and need a quick fix.

In fact, I started up with more radical changes before backing up and go for something easier to follow. If you wish, i can complete it and push that branch on my fork for you to look at.