search

zpelgrims / zoic

Extended camera shader for the ever-awesome Arnold Renderer
http://www.zenopelgrims.com/zoic
67 stars 25 forks source link

use node local storage to store camera and image data #5

Closed gatgui closed 8 years ago

gatgui commented 8 years ago

get rid of global and use node local data instead additionally, properly release allocated resources in node_update/node_finish

zpelgrims commented 8 years ago

Hey man! Thanks so much for removing that OIIO dependency. It had been bugging me for a while! Your proposed way is much better. Also can't believe you cleaned up my code massively.. Legend!

zpelgrims commented 8 years ago

I'm unsure about one thing now - you adjusted the code for me to have the option to compile with the oiio dependency. I don't need this any more, right? Any reason you left it in?

gatgui commented 8 years ago

Thanks for your message.

That wasn't actually much but I'm glad you appreciated it. I was interested in seeing your camera shader at work and often find myself fighting with dependencies (especially on Windows ;)) so i thought that i may just jump in and give a hand!

I left your original code using oiio because i thought that some people may be stuck with Arnold version older than 4.2.10.0 (stay away from 4.2.9.0) for production reasons (versions are usually locked at the beginning). So having oiio support can still be helpful.

Cheers, Gaetan

On Feb 24, 2016, at 21:13, Zeno Pelgrims notifications@github.com wrote:

I'm unsure about one thing now - you adjusted the code for me to have the option to compile with the oiio dependency. I don't need this any more, right? Any reason you left it in?

― Reply to this email directly or view it on GitHub.