search

zpix1 / yt-anti-translate

Chrome extension to disable youtube video titles autotranslation
MIT License
56 stars 8 forks source link

Memory leak and micro stutters tabs with playlists #29

Open vBardys opened 1 month ago

vBardys commented 1 month ago

When I open a lengthy playlist ( https://www.youtube.com/playlist?list=PLa5rLV8WvIPFvdncJTSh9ipowFjUtwc9o ) with the addon enabled I will get micro stutters, prompts with '[addon name] is slowing down Firefox. To speed up your browser, stop that extension.' where [addon name] keeps changing between different installed addons but mostly shows 'Youtube anti translate'.

Disabling this addon and restarting firefox makes browsing playlists work again.

Until I fully restart firefox or press 'Stop' in the above slowing down prompt RAM consumption for firefox will keep going up until all is used.

Firefox 128.0.3 (64-bit)

Enabled addons:

Enhancer for YouTube™

Extension ID enhancerforyoutube@maximerf.addons.mozilla.org Internal UUID 0ada0e5d-26a6-45a9-a981-cc792d16d7f4 Manifest URL moz-extension://0ada0e5d-26a6-45a9-a981-cc792d16d7f4/manifest.json

FFS MSDN in English

Extension ID {b3abf5b1-5525-4838-b84f-c152a772f3a8} Internal UUID b36e0158-1741-4e77-872e-b17ca21b905b Manifest URL moz-extension://b36e0158-1741-4e77-872e-b17ca21b905b/manifest.json

SponsorBlock for YouTube - Skip Sponsorships

Extension ID sponsorBlocker@ajay.app Internal UUID 2167092d-ed4c-4f9d-8bd0-880811aa8dff Manifest URL moz-extension://2167092d-ed4c-4f9d-8bd0-880811aa8dff/manifest.json Background script Running

Tampermonkey

Extension ID firefox@tampermonkey.net Internal UUID 87d6182e-6702-4fd4-8e91-d96b92f5018f Manifest URL moz-extension://87d6182e-6702-4fd4-8e91-d96b92f5018f/manifest.json Background script Running

uBlock Origin

Extension ID uBlock0@raymondhill.net Internal UUID f4595840-43a9-44f9-b9c8-cd744c7c3a1c Manifest URL moz-extension://f4595840-43a9-44f9-b9c8-cd744c7c3a1c/manifest.json

YouTube Anti Translate

Extension ID {458160b9-32eb-4f4c-87d1-89ad3bdeb9dc} Internal UUID c029ff9a-df61-46f7-ac1e-7973f5bdf3c9 Manifest URL moz-extension://c029ff9a-df61-46f7-ac1e-7973f5bdf3c9/manifest.json

Console logs console-export-2024-7-30_20-24-56.txt ... [YoutubeAntiTranslate] Setting main video title background.js:194:17 [YoutubeAntiTranslate] translated title from "" to "ddt4all" background.js:196:17 [YoutubeAntiTranslate] entered untranslateOtherVideos background.js:292:13 [YoutubeAntiTranslate] untranslateArray 0 items 4 background.js:294:17 [YoutubeAntiTranslate] untranslateArray 31 items background.js:294:17 TypeError: null has no propertiesbackground.js:257:25 untranslateChannelViewMainVideo moz-extension://c029ff9a-df61-46f7-ac1e-7973f5bdf3c9/src/background.js:257 untranslateOtherVideos moz-extension://c029ff9a-df61-46f7-ac1e-7973f5bdf3c9/src/background.js:372 untranslate moz-extension://c029ff9a-df61-46f7-ac1e-7973f5bdf3c9/src/background.js:392 baka moz-extension://c029ff9a-df61-46f7-ac1e-7973f5bdf3c9/src/background.js:416 ...

artisticfox8 commented 1 month ago

Hi, I think this bug is a duplicate of https://github.com/zpix1/yt-anti-translate/issues/28.

artisticfox8 commented 1 month ago

Please try release 1.5.14.1 to confirm the problem is fixed.

To try it:

  1. On that page, click Source code (zip)
  2. Uncompress the zip file, the app folder is what you need => put it in some folder you'll easily find
  3. In Firefox, go to about:debugging and choose This Firefox
  4. Click Load temporary addon
  5. Select manifest.json from that app folder you saved.
  6. The extension is installed, you can open YouTube and test playlists

If it doesn't cause this issue anymore, I will release it

vBardys commented 1 month ago

Hey,

Seems to work fine with the 1.5.14.1 loaded as temporary addon.

image

Will keep testing for a couple of days and let you know here.

vBardys commented 1 month ago

Still fine although I did not have it running all the time due to restarts of the browser and having to reload it back into temp extensions.