search

zpl-c / enet

⚡️ ENet reliable UDP networking library
https://blog.zpl.pw
MIT License
650 stars 62 forks source link

Remove compression functionality #5

Closed nxrighthere closed 5 years ago

nxrighthere commented 5 years ago

An additional cleanup to https://github.com/zpl-c/enet/commit/8c8cc837f24b76c816ed05f67228d988372fb865, and minor formatting changes.

nxrighthere commented 5 years ago

On hold/under consideration.

zpl-zak commented 5 years ago

Is there a reason for its removal?

nxrighthere commented 5 years ago

Well, @inlife told me that he's going to use this functionality in librg, so these changes are currently on hold. In general, it's not a big deal to remove it or not, but less code to maintain is always better.

zpl-zak commented 5 years ago

The thing is, isn't compression supposed to be considered as one of features that are irreplacable? Meaning, if we remove compression completely, can it be equally substituted from a higher level?

nxrighthere commented 5 years ago

Yea, this is done at a high-level in my networking layer. If I understand correctly, he wants to keep these callbacks to make compression possible at low-level for some reason.

Croydon commented 5 years ago

@nxrighthere I gave this pull request a thumbs down because I'm thinking that having compression directly in enet is a huge advantage. I didn't comment here since I assumed that it's clear what a thumbs down in a pull request which removes a feature means.

I noticed that you gave random issues I have opened in at least two completely different, unrelated projects a thumbs down for no apparently reason other than trolling.

I'm sorry if you did interpret my thumbs down as some kind of bulling or trolling, this was not my intention.

However, even if somebody is trolling you, you shouldn't go down the same path.

nxrighthere commented 5 years ago

I'm thinking that having compression directly in enet is a huge advantage

No problem, show me where you use it in practice.