search

zplizzi / pytorch-ppo

Simple, readable, yet full-featured implementation of PPO in Pytorch
44 stars 7 forks source link

Should epoch loop be inside or outside batch loop? #4

Open zplizzi opened 2 years ago

zplizzi commented 2 years ago

https://github.com/zplizzi/pytorch-ppo/blob/master/main.py#L132

zplizzi commented 2 years ago

yeah, this is definitely backwards. should go through all batches each epoch.