zploskey / ExperimentalBeijing

Experimental Beijing site based on Omeka in English and Chinese
http://experimentalbeijing.com
GNU General Public License v3.0
2 stars 1 forks source link

People: show About info next to image #27

Closed zploskey closed 6 years ago

zploskey commented 6 years ago

While I'm working on this, this block of info displayed here looks like this in the spec:

Last Name:   Chen
First Name:  Lingyang
Gender:      Female
Culture:     Chinese
Birth Date:  1975

Most people don't seem to have First Name and Last Name filled out, so a name isn't being displayed at all. I was thinking maybe we just make the name part

Name: Chen Lingyang

where we just call the Title field "Name" on People pages and display the text for the Title there. This slightly reduces the vertical space taken up and requires less fiddling with adding that metadata in the admin.

zploskey commented 6 years ago

Although actually the spec has the Title field displayed above the photo, which is inconsistent with how other Item pages display. Is this still what we're looking for?

image

zploskey commented 6 years ago

It should look pretty close to that design now. Let me know if there's anything we need to revisit in the design.

swelland commented 6 years ago

Hi Zach,

On the people page, I agree with you that it’s probably better to be consistent with the other item pages and remove the title field from above the photo. I think, however, that it’s best to keep the five categories Siyi used to the right of the image: last name, first name, gender, culture, birth date, especially given the confusion often associated with Chinese first and last name order.

Sasha

On Apr 18, 2018, at 2:16 PM, Zach Ploskey notifications@github.com wrote:

Although actually the spec has the Title field displayed above the photo, which is inconsistent with how other Item pages display. Is this still what we're looking for?

https://user-images.githubusercontent.com/542191/38958745-01376bbc-4313-11e8-9681-f16f30a228dd.png — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/zploskey/ExperimentalBeijing/issues/27#issuecomment-382532142, or mute the thread https://github.com/notifications/unsubscribe-auth/AM0Tso2nk6QwLyatovLZnSl5i4JN49U3ks5tp60tgaJpZM4SpmpR.

zploskey commented 6 years ago

Currently the complete title field is being displayed above everything else. I actually feel like having the title (their full name without labels for first and last) displayed somewhere is good. Initially I thought that the title was not displayed, which prompted me to file this issue. I can remove it if that is what you want, but I feel like it does look OK. First and Last Name fields will only show up if they are added for each person item, and each will need to have the translation set as well.

swelland commented 6 years ago

Yes, I agree that it looks fine to have the title displayed. First and Last Name fields as filled out are not yet showing. For example, I just checked Pan Yuliang in Omeka. First and Last Name fields are filled out (with the translation set) but they don't appear yet on her person/item page to the right of her image.

zploskey commented 6 years ago

These were set to hidden in the Hide Elements plugin, since there was a time where we only used these on the initial import and wanted them hidden. I unhid them (under Plugins -> Configure on Hide Elements -> unchecking all boxes next to "First Name" and "Last Name") and they now show up.