search

zploskey / bs-puppeteer

Bucklescript bindings for Puppeteer (Headless Chrome Node API) written in ReasonML
MIT License
62 stars 13 forks source link

Changed jsonValue return type to be Js.Json.t #124

Closed leeor closed 4 years ago

leeor commented 4 years ago

Puppeteer docs describe jsonValue() as returning a JSON representation of the object. In some cases the object is simply a string (such as getting a property as the test case does), for these cases, using a Js.Json.t return type is more robust.

zploskey commented 4 years ago

Good call. Js.Json.t is definitely an improvement here. Thank you so much for contributing!