Closed fennecdjay closed 7 years ago
Sure thing.
anything else ?
- test it fails if plugin is not installed
we migth need the plugin_entry_exists()
for that, maybe I should do it first.
what do you think?
we migth need the plugin_entry_exists() for that, maybe I should do it first. what do you think?
That would also be useful for https://github.com/zpm-project/zpm-zsh/issues/1. So yes.
I'm skipping the /tmp/.zpm.tmp
test for now, as I don't know how to handle a non readable /tmp
directory.
Should we move this location (to $PWD, for instance)?
For the time being I'm OK with having /tmp fixed.
For the time being I'm OK with having /tmp fixed.
I'm afraid I'm not sure what this really means.
I meant it's ok as it's now.
DC* Sent from mobile.
We probably need to merge #14 before I go ahead, as it ships plugin_entry_exists()
and this function is needed or this feature.
Its a shame, but I'm still in trouble with rebase... Could we please close that PR, and I'll do anoher (hopefully cleaner one) based one current HEAD?
but I'll definitely give rebase a closer look ;-)
git-rebase
can be tricky. Alright I'm closing this.
Great. I remember you suggested renaming those commands, yet I can't find the place you did anymore. If you could refresh my memory, it would be nice 😆 .
I thought about using:
disable
for remove
remove
for uninstall
Here's there comment.
What do you think? Make sense?
Yes, this is far better.
Thanks for the link. it looks like and can't access desyncr/zpm-zsh issues anymore.
I disabled it so we can leave desyncr/zpm-zsh
behind. I enabled it again so we can view all previous conversations.
😄 I didn't even know that was possible.
If you go to, say, https://github.com/fennecdjay/Gwion/settings, you'll see the option under "Features". Pretty neat.
Thank you.
Also use double-quotes in usage().