Remove/uninstall

[fennecdjay]

Also use double-quotes in usage().

[fennecdjay]

Sure thing.

• test it works if no file
• test it fails if plugin is not installed
• test directory is removed
• test parent directory is removed if empty
• test /tpm/.zpm.tmp is removed

anything else ?

• test it fails if plugin is not installed

we migth need the plugin_entry_exists() for that, maybe I should do it first. what do you think?

[desyncr]

we migth need the plugin_entry_exists() for that, maybe I should do it first. what do you think?

That would also be useful for https://github.com/zpm-project/zpm-zsh/issues/1. So yes.

[fennecdjay]

I'm skipping the /tmp/.zpm.tmp test for now, as I don't know how to handle a non readable /tmp directory. Should we move this location (to $PWD, for instance)?

[desyncr]

For the time being I'm OK with having /tmp fixed.

[fennecdjay]

For the time being I'm OK with having /tmp fixed.

I'm afraid I'm not sure what this really means.

[desyncr]

I meant it's ok as it's now.

DC* Sent from mobile.

[fennecdjay]

We probably need to merge #14 before I go ahead, as it ships plugin_entry_exists() and this function is needed or this feature.

[fennecdjay]

Its a shame, but I'm still in trouble with rebase... Could we please close that PR, and I'll do anoher (hopefully cleaner one) based one current HEAD?

---

but I'll definitely give rebase a closer look ;-)

[desyncr]

git-rebase can be tricky. Alright I'm closing this.

[fennecdjay]

Great. I remember you suggested renaming those commands, yet I can't find the place you did anymore. If you could refresh my memory, it would be nice 😆 .

[desyncr]

I thought about using:

• disable for remove
• remove for uninstall

Here's there comment.

What do you think? Make sense?

[fennecdjay]

Yes, this is far better.

Thanks for the link. it looks like and can't access desyncr/zpm-zsh issues anymore.

[desyncr]

I disabled it so we can leave desyncr/zpm-zsh behind. I enabled it again so we can view all previous conversations.

[fennecdjay]

😄 I didn't even know that was possible.

[desyncr]

If you go to, say, https://github.com/fennecdjay/Gwion/settings, you'll see the option under "Features". Pretty neat.

[fennecdjay]

Thank you.