Closed desyncr closed 7 years ago
It's failing but that's cool because it's only the tests are not passing on OS X, which we already knew.
Looks good. Can cram handle variables in return values? I didn't manage to do that. maybe
if [ $TRAVIS_OS_NAME = "osx" ]; then sed -i '' 's/\[2\]/[1]/' tests/remove.t; fi
would do
@fennecdjay No it does not. We should not adapt tests for each OS. The same behaviour should be displayed regardless of OS.
We should see why return codes won't match on OS X with what's expected to. The root issue is ls
return code for non-existing directories is 1
(bsd) vs 2
(gnu).
I have changed the check from using ls
to [ -d $dir ]
. Which seems to be more reliable.
I have changed the check from using ls to [ -d $dir ]. Which seems to be more reliable.
Nice Idea!
ls return code for non-existing directories is 1 (bsd) vs 2 (gnu). Nice catch too!
ls return code for non-existing directories is 1 (bsd) vs 2 (gnu). Nice catch too!
Travis CI's OS X builds are so terrible slow lately. It's painful.
This is something I've seen previously. It seems zpm
enters on some condition it should not. https://travis-ci.org/zpm-project/zpm-zsh/jobs/199239904#L802
Done!
No need to be sorry that's part of the job :P
Fixes #21