search

zpm-project / zpm-zsh

zsh plugin manager in ansi C.
GNU General Public License v3.0
5 stars 3 forks source link

Add OS X to travis ci configuration #25

Closed desyncr closed 7 years ago

desyncr commented 7 years ago

Fixes #21

desyncr commented 7 years ago

It's failing but that's cool because it's only the tests are not passing on OS X, which we already knew.

fennecdjay commented 7 years ago

Looks good. Can cram handle variables in return values? I didn't manage to do that. maybe

if [ $TRAVIS_OS_NAME = "osx" ]; then sed -i '' 's/\[2\]/[1]/' tests/remove.t; fi

would do

desyncr commented 7 years ago

@fennecdjay No it does not. We should not adapt tests for each OS. The same behaviour should be displayed regardless of OS.

We should see why return codes won't match on OS X with what's expected to. The root issue is ls return code for non-existing directories is 1 (bsd) vs 2 (gnu). I have changed the check from using ls to [ -d $dir ]. Which seems to be more reliable.

fennecdjay commented 7 years ago

I have changed the check from using ls to [ -d $dir ]. Which seems to be more reliable.

Nice Idea!

fennecdjay commented 7 years ago

ls return code for non-existing directories is 1 (bsd) vs 2 (gnu). Nice catch too!

fennecdjay commented 7 years ago

ls return code for non-existing directories is 1 (bsd) vs 2 (gnu). Nice catch too!

desyncr commented 7 years ago

Travis CI's OS X builds are so terrible slow lately. It's painful.

desyncr commented 7 years ago

This is something I've seen previously. It seems zpm enters on some condition it should not. https://travis-ci.org/zpm-project/zpm-zsh/jobs/199239904#L802

desyncr commented 7 years ago

Done!

desyncr commented 7 years ago

No need to be sorry that's part of the job :P