zpm-project / zpm-zsh

zsh plugin manager in ansi C.
GNU General Public License v3.0
5 stars 3 forks source link

Save command. At last #7

Closed fennecdjay closed 7 years ago

fennecdjay commented 7 years ago

Still much work left, but it is good to see this here.

rmdir_r() was probably failng do to read-only permission, a simple to chmod() migth be able to fix that, I'll make a PR when ready.

desyncr commented 7 years ago

Wanna try merging master back into save_command?

 git checkout save_command
 git fetch --all
 git merge master

You probably will need to update your remotes by pointing to zpm-project/zpm-zsh rather than desyncr/zpm-zsh, now deprecated.

git remote rm upstream
git remote add upstream git@github.com:zpm-project/zpm-zsh.git

Let me know if you have any issues with git.

fennecdjay commented 7 years ago

Let me know if you have any issues with git.

Thank you. I'll probably stick with my fork for origin, but switch upstream remote from desyncr/zpm-zsh to zpm-project/zpm-zsh

desyncr commented 7 years ago

If you could perform a rebase, even better.

git checkout save_command
git fetch upstream
git rebase upstream/master
fennecdjay commented 7 years ago

I'm afraid i get some trouble with rebase. ... I'll keep working :-)

fennecdjay commented 7 years ago

Can you please close this? we'll still be able to access the discussion, but I'd like to split it in smaller PRs:

each with corespondiong usage() entry when needed. I'll leave the README.md updating up to you.

desyncr commented 7 years ago

Alright. I'm gonna close this now.