search

zpnk / stage-ci

Automatic deploy previews for your PRs using zeit.co/now.
https://stage.now.sh
MIT License
131 stars 23 forks source link

Deploy failed twice #22

Closed kentcdodds closed 7 years ago

kentcdodds commented 7 years ago

Unfortunately there's not any log or anything :-(

screen shot 2017-05-30 at 9 23 51 am
kentcdodds commented 7 years ago

I got this deploying ok manually. So there's something weird about the deploy button I guess.

zpnk commented 7 years ago

Hey @kentcdodds 👋 - sorry you ran into this issue. The deploy button currently does not support Docker based deploys as mentioned in #12. Hopefully I will have some time soon to fix that in the deploy.now project.

The manual deploy works as the now-cli correctly detects the Docker project.

kentcdodds commented 7 years ago

Perhaps we should note this in the README 🤔

jimthedev commented 7 years ago

To be honest, the deploy button is nice but ultimately the lack of docker support might just end up causing more confusion. What do you think about having the primary communicated method be to manually set it up with a special note that you can try the alpha web ui if you're not using docker. This might reprioritize the communication to emphasize supported features. I'd also ideally love to see this move to an organization with some consolidation of repos. Docs being separate actually makes it pretty hard to reason about.

zpnk commented 7 years ago

deploy.now now has docker support! (zpnk/deploy.now#8) The deploy button on https://stage.now.sh/ should finally work, haha.

@jimthedev Thanks for the note about changing the docs - if we continue to run into issues with the deploy button, I'm definitely for figuring out a better way of communicating the installation method.

Also, re: GH org/repo consolidation: all for consolidating zpnk/stage.now & zpnk/stage-ci. Any advice for going about this? I think zpnk/stage-ci should stay the "canonical" repo because it has all the issues/PRs, but the stage.now name makes more sense. For an org - any name suggestions? Would ideally house zpnk/deploy.now and the stage project.

Closing this issue, but let's open a new issue to further discuss the GH org/repo unification!

paulirish commented 7 years ago

Closing this issue, but let's open a new issue to further discuss the GH org/repo unification!

When you do this, I have a few things to add. 🤓