zpnk / stage-ci

Automatic deploy previews for your PRs using zeit.co/now.
https://stage.now.sh
MIT License
131 stars 23 forks source link

Fix Docker deployments 🐳 #48

Open hugomd opened 6 years ago

hugomd commented 6 years ago

Resolves #47, fixes #39, #43

I've updated the Dockerfile to use the node:10-alpine image, and to pull the latest version of now with Alpine support (11.2.1). I would have pulled 8.3.9 which is what the rest of the code uses, but the binary doesn't seem to work on Alpine at all 🤔

I've tested pretty extensively and it seems to be quite stable ✅

I'd like to make another PR to update now version that we pull for npm based deployments to 11.2.1, that way we shouldn't have any compatibility issues from now across npm and docker deployments.