search

zpnk / stage-ci

Automatic deploy previews for your PRs using zeit.co/now.
https://stage.now.sh
MIT License
131 stars 23 forks source link

Add repo owner to alias url. #8

Open zpnk opened 7 years ago

zpnk commented 7 years ago

The current alias structure is of the form: {repo-name}-{my-branch}.

I think we should add the repo owner to the alias, for example: zpnk-hello-world-some-changes.

This will prevent collisions on project forks, etc.

hawkins commented 7 years ago

Is there any reason you don't use a hash or anything to practically guarantee collisions altogether?

For instance, if you pulled the branch's latest commit, you could take that commit's hash's first 7 digits and integrate it into the alias, similar to how non-aliased now deploys get named package-name-hashgoeshere.now.sh.

If you did this, the structure could be {user-name}-{repo-name}-{branch-name}-{commit-hash}. Granted this may be too long at this point, so you might consider cutting out the branch-name since that's now redundant, I think