Improvements for Distributed

zpp-2022-rust-seastar / seastar-rs

Idiomatic Rust bindings to the Seastar framework

6 stars 3 forks source link

Improvements for Distributed #46

Closed kfernandez31 closed 1 year ago

kfernandez31 commented 1 year ago

This branch introduces:

missing safety checks (kind of a big deal),
more types of maps for a more ergonomic API. The ones that existed before now have their _mut counterparts, which allow for regular mutability, instead of interior mutability. Note, however, that stop still requires interior mutability, should you want to alter the service's state.
the much-awaited functionality of peering_sharded_service, through which instances can communicate and delegate work.

kfernandez31 commented 1 year ago

v2 - resolved @piodul 's comments apart from this one:

Another thing is the "Peering" part. Due to the problems highlighted above, I don't think map_mut and friends should provide access to the container because it would allow creating more references to the same shard-local instances.

I'd like to know whether the security checks I added have addressed your concerns or should I go ahead and rescind the access to the container of mut-maps.

kfernandez31 commented 1 year ago

v3: further comment resolution @piodul review ping