zpydr / gnome-shell-extension-taskbar

GNOME Shell Extension TaskBar
https://extensions.gnome.org/extension/584/taskbar/
153 stars 63 forks source link

Request gnome-shell 3.30 support #197

Open dino99 opened 6 years ago

dino99 commented 6 years ago

Using Ubuntu Cosmic (18.10) Since the upgrade to Gnome-shell and mutter 3.29.90 , TaskBar extension has stopped working.

Hopes you update that useful extension very soon.

smcv commented 6 years ago

According to codesearch.debian.net, this extension uses the MetaScreen via global.screen. MetaScreen no longer exists in GNOME 3.29, which has reached hard code freeze and will be released as 3.30 soon. This extension will need code changes to use the MetaDisplay (global.display), MetaWorkspaceManager (global.workspace_manager), MetaMonitorManager (Meta.MonitorManager.get()) or MetaX11Display (global.display.get_x11_display()).

Because GNOME 3.29/3.30 is not a stable release yet, you'll probably need to condition on the GNOME Shell version.

A similar pull request for another extension: mlutfy/hidetopbar#163

(Sorry, I do not use this extension myself and so will not be able to provide or test patches.)

bklaas commented 6 years ago

3.30 is being pushed to Arch users now, so this issue is hitting more people.

bklaas commented 6 years ago

Confirmed, using patch from Issue #200 fixes this for gnome-shell 3.30. Recommend merging PR.

dino99 commented 6 years ago

Proposed update fork https://github.com/lotan/gnome-shell-extension-taskbar/commit/763fee2c7e8fc9fc8ed2976fc7fb70a3fd7baabd

lsatenstein commented 6 years ago

Hi Everybody. I am delighted to say that Lotan's patches appear to work fantastically.  Here is my comments.

I have just tested it on Fedora 29 beta and the patch appears to work as the original before Gnome 3.30 came along. The second issue I had with parameter adjustments no longer crashes TaskBar I would like to test it on Fedora 28 and with Suse Tumbleweed's Gnome versions and respond one more time. I will respond by Tomorrow morning, Wednesday AM,  if not sooner. I would also like to suggest a new import.sh    TaskBar@zpydr/scripts/import.sh  and an accompanying file (taskbar.conf) What is relevant about this script and taskbar.conf? The import.sh script looks at $HOME for taskbar.cnf and if it does not find it there, looks in the scripts directory.If that one exists, it copies it to $HOME. and allows it to be used. If neither taskbar.conf file exists, then the default action is as before.

That tasbar.cnf within the scripts folder can be distributed as the default TB download or git clone.

What this script change does is allows one to fully package the TB extension as one single directory along with taskbar.conf.

I propose this script as an additional change to lotan's fine work. Simply because I email the TB within a single tarfile and the taskbar.conf therein simplifies an enduser's setup. One consideration.  If taskbar is made global (  /usr/share/....  in place of $HOME/.local), the script will have to be tweaked to make it work from the global location. I can do this script change  for Tomorrow am too.

Regards  Leslie Leslie Satenstein Montréal Québec, Canada

  ============See attachment.No change for front part #

  Revised to look in scripts location for taskbar.dconf if it does not exist

  within $HOME. cp former to $HOME and invoke it

# tb='.local/share/gnome-shell/extensions/TaskBar@zpydr' if [ ! -f $HOME/taskbar.dconf ]; then

   if there is a default taskbar.dconf copy it to $HOME

    if [ ! -f $HOME/${tb}/scripts/taskbar.dconf ]; then         zenity --info --text 'Import of TaskBar Settings Failed!'     else          cp $HOME/${tb}/scripts/taskbar.dconf $HOME          zenity --info --text 'taskbar.dconf imported!' && gnome-shell-extension-prefs TaskBar@zpydr          dconf load /org/gnome/shell/extensions/TaskBar/ <$HOME/taskbar.dconf          killall gnome-shell-extension-prefs          zenity --info --text 'Import of TaskBar Settings Successful!' && gnome-shell-extension-prefs TaskBar@zpydr     fi else      dconf load /org/gnome/shell/extensions/TaskBar/ <$HOME/taskbar.dconf      killall gnome-shell-extension-prefs      zenity --info --text 'Import of TaskBar Settings Successful!' && gnome-shell-extension-prefs TaskBar@zpydr fi

What is relevent about this script?The import looks at $HOME for taskbar.cnf and if it does not find it there, looks in the scripts directory.If that one exists, it copies it to $HOME.If neither exists, then the default action is as it was. That tasbar.cnf within the scripts folder can be distributed as the defaults What this change does is allows one to fully package the TB extension as one single directory.I propose this as an additional change. Simply because I email the TB within a single tarfile and the taskbar.conf is therein

Regards  Leslie Leslie Satenstein Montréal Québec, Canada

On Monday, October 8, 2018, 11:10:18 p.m. EDT, dino99 <notifications@github.com> wrote:  

Proposed update fork lotan@763fee2

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

lsatenstein commented 6 years ago

My testing with Fedora 28, xorg and wayland was successfulMy testing with SUSE Tumbleweed xorg and wayland was successful

My testing with Fedora 29 is not successful Problems.any enable/disable kills taskbarany modification to a toggle on/off  within taskbar kills taskbar. but if you use the shellscript concept, you can import the settings for dconf editor and have taskbar.dconf set it upif on Fedora xorg (gnome 330), alt-r restarts the shell session and Taskbar is presented.All icons therein function. So, if you have it running, leave it alone By the way, attached is an updated script to TaskBar/scripts/import.sh

Regards  Leslie Leslie Satenstein Montréal Québec, Canada

On Tuesday, October 9, 2018, 1:44:10 p.m. EDT, Leslie S Satenstein <lsatenstein@yahoo.com> wrote:  

Hi Everybody. I am delighted to say that Lotan's patches appear to work fantastically.  Here is my comments.

I have just tested it on Fedora 29 beta and the patch appears to work as the original before Gnome 3.30 came along. The second issue I had with parameter adjustments no longer crashes TaskBar I would like to test it on Fedora 28 and with Suse Tumbleweed's Gnome versions and respond one more time. I will respond by Tomorrow morning, Wednesday AM,  if not sooner. I would also like to suggest a new import.sh    TaskBar@zpydr/scripts/import.sh  and an accompanying file (taskbar.conf) What is relevant about this script and taskbar.conf? The import.sh script looks at $HOME for taskbar.cnf and if it does not find it there, looks in the scripts directory.If that one exists, it copies it to $HOME. and allows it to be used. If neither taskbar.conf file exists, then the default action is as before.

That tasbar.cnf within the scripts folder can be distributed as the default TB download or git clone.

What this script change does is allows one to fully package the TB extension as one single directory along with taskbar.conf.

I propose this script as an additional change to lotan's fine work. Simply because I email the TB within a single tarfile and the taskbar.conf therein simplifies an enduser's setup. One consideration.  If taskbar is made global (  /usr/share/....  in place of $HOME/.local), the script will have to be tweaked to make it work from the global location. I can do this script change  for Tomorrow am too.

Regards  Leslie Leslie Satenstein Montréal Québec, Canada

  ============See attachment.No change for front part #

  Revised to look in scripts location for taskbar.dconf if it does not exist

  within $HOME. cp former to $HOME and invoke it

# tb='.local/share/gnome-shell/extensions/TaskBar@zpydr' if [ ! -f $HOME/taskbar.dconf ]; then

   if there is a default taskbar.dconf copy it to $HOME

    if [ ! -f $HOME/${tb}/scripts/taskbar.dconf ]; then         zenity --info --text 'Import of TaskBar Settings Failed!'     else          cp $HOME/${tb}/scripts/taskbar.dconf $HOME          zenity --info --text 'taskbar.dconf imported!' && gnome-shell-extension-prefs TaskBar@zpydr          dconf load /org/gnome/shell/extensions/TaskBar/ <$HOME/taskbar.dconf          killall gnome-shell-extension-prefs          zenity --info --text 'Import of TaskBar Settings Successful!' && gnome-shell-extension-prefs TaskBar@zpydr     fi else      dconf load /org/gnome/shell/extensions/TaskBar/ <$HOME/taskbar.dconf      killall gnome-shell-extension-prefs      zenity --info --text 'Import of TaskBar Settings Successful!' && gnome-shell-extension-prefs TaskBar@zpydr fi

What is relevent about this script?The import looks at $HOME for taskbar.cnf and if it does not find it there, looks in the scripts directory.If that one exists, it copies it to $HOME.If neither exists, then the default action is as it was. That tasbar.cnf within the scripts folder can be distributed as the defaults What this change does is allows one to fully package the TB extension as one single directory.I propose this as an additional change. Simply because I email the TB within a single tarfile and the taskbar.conf is therein

Regards  Leslie Leslie Satenstein Montréal Québec, Canada

On Monday, October 8, 2018, 11:10:18 p.m. EDT, dino99 <notifications@github.com> wrote:  

Proposed update fork lotan@763fee2

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

aek commented 6 years ago

In Ubuntu 18.04 the lotan branch shows the icons and load the panel properly, at least the taskbar, but when I clic on any icon it is crashing the Gnome Shell

lsatenstein commented 6 years ago

Taskbar is stable, once you complete all your settings. I exported my settings and in Gnome 33x imported them. Taskbar works fine for me.

Sent from Yahoo Mail on Android

On Mon, 22 Oct 2018 at 10:39 AM, Axel Mendozanotifications@github.com wrote:
In Ubuntu 18.04 the lotan branch is crashing the Gnome Shell

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

grizzlysmit commented 6 years ago

on 18.10 the lotan fork does not work it crashes stuff like the bottom bar and the Ubuntu dash/dock gnome shell version is GNOME Shell 3.30.1

dino99 commented 5 years ago

Looks like that extension is now deprecated: dropped from Disco (Ubuntu 19.04) archive.

cloph commented 5 years ago

Weird way of thinking there… No point in packaging something that's not tweaked to work with that other packages the distro ships (and I have no idea how far they are from vanilla gnome desktop in 19.x)... It's unfortunate that there's no official new release though with the current code.. Did ubuntu replace it with a different extension then?

corradoventu commented 5 years ago

according this page: https://extensions.gnome.org/extension/584/taskbar/ taskbar extension will no longer mantained

cloph commented 5 years ago

ah, too bad :-( - but that makes it definitive then. Happy to hear suggestions for replacements on same level as this extension...

lsatenstein commented 5 years ago

I visited github and took down a version that works with Gnome 3.30.  I can zip it up and send you a copy as an attachment.  If you want that copy that works for me, I need to have a subject line   TASKBAR  so I don't wipe that email request by accident.

Regards  Leslie Leslie Satenstein Montréal Québec, Canada lsatenstein@yahoo.com

On Tuesday, November 20, 2018, 10:50:29 a.m. EST, cloph <notifications@github.com> wrote:  

Weird way of thinking there… No point in packaging something that's not tweaked to work with that other packages the distro ships (and I have no idea how far they are from vanilla gnome desktop in 19.x)... It's unfortunate that there's no official new release though with the current code.. Did ubuntu replace it with a different extension then?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

dino99 commented 5 years ago

In case someone will try a new design, i've found that smart project very interesting and documented via valadoc https://github.com/p-e-w/argos