search

zpzim / SCAMP

The fastest way to compute matrix profiles on CPU and GPU!
http://www.cs.ucr.edu/~eamonn/MatrixProfile.html
MIT License
159 stars 36 forks source link

Selfjoin calculation error on numpy>2 #129

Open amR0ssi opened 2 months ago

amR0ssi commented 2 months ago

Hi there,

Thanks for a great library! Just found this after being a stumpy user for some time. It truly is fast. Testing pyscamp I noticed that numpy version >=2 seems to break something and the calculation produces a constant vector as result: image

With numpy<2 works as expected: image

BR, Antti

zpzim commented 1 month ago

Thanks for reporting this! I will take a look at ensuring that numpy 2 plays nicely with pyscamp.

Are you using the conda forge package? Or installing from pip?

amR0ssi commented 1 month ago

I tried both the conda-forge and pip before realizing it is a numpy issue. I think I ended up with the pip installation.

zpzim commented 1 month ago

Alright, for now one solution is to update the requirements to state numpy < 2, though this is not ideal. When I get some time to look at this I'll see if I can fix.