zqgao22 / HIGH-PPI

MIT License
72 stars 11 forks source link

Questions about the Metrictor_PPI function #2

Closed wan-nie closed 1 year ago

wan-nie commented 1 year ago

I would like to express my gratitude for making the code open-source. I have a question regarding the Metrictor_PPI function in HIGH-PPI/utils.py and I was hoping you could assist me.

zqgao22 commented 1 year ago

Hi, Wan. Thank you very much for pointing this issue. You are right. For Sklearn's precision_recall_curve function, we need to take the predicted probability as the second entry. In fact, the result of our source data is calculated with a simpler function average_precision_score, which also requires the predicted probability scores. However, we later tried to rewrite it to a more widely used precision_recall_curve function and ignored the above problem. We are about to modify it to the correct form.

wan-nie commented 1 year ago

Hi, Ziqi. Thank you for the prompt reply. As the results were correctly calculated using the predicted probability, I think this issue can be closed now.