zqhang / AnomalyCLIP

Official implementation for AnomalyCLIP (ICLR 2024)
MIT License
284 stars 29 forks source link

Pure leakage in the test set #9

Closed FudaMingdaXsc closed 7 months ago

FudaMingdaXsc commented 7 months ago

It seems that you used the entire test set to train encode_text_learn, while also using the test set for testing, which is seriously inconsistent with the ZERO-SHOT mentioned in your paper.Can you explain this issue

zqhang commented 7 months ago

We conduct zero-shot performance evaluations on datasets other than MVTEC AD using the test set of MVTEC AD dataset. And, we assess the zero-shot performance on the MVTEC AD dataset using the test set of VisA dataset. This aligns with the approach presented in our paper. You can check the script train.sh and test.sh

FudaMingdaXsc commented 7 months ago

Thank you very much for your reply. Your explanation convinced me that your ZERO-SHOT approach is different from others' ZERO-SHOT approach. It's a great idea and worth following by others

zqhang commented 7 months ago

Thanks for your acknowledgment, I will close this issue.