i know you could do this yourself but i did it anyway

zqqw / pakku

Pacman wrapper with AUR support

GNU General Public License v3.0

39 stars 3 forks source link

i know you could do this yourself but i did it anyway #10

Closed shirleyquirk closed 3 years ago

shirleyquirk commented 3 years ago

resolves #9 lets pakku compile with 1.5.1 with no warnings. ...for now checked on 1.4, 1.2 as well

shirleyquirk commented 3 years ago

the change in format.nim was because of the next build error that came up after the fix in createCloneProcess the next error that comes up with 1.5.1 is:

src/feature/syncinstall.nim(329, 14) template/generic instantiation of `choices` from here
src/format.nim(300, 14) Error: error got nnkTupleConstr

the line is:

329        choices('y', 'n', ('s', tr"skip all"), ('a', tr"abort operation")),

i suppose a subtle parsing change from nnkPar to nnkTupleContr. in that situation.

zqqw commented 3 years ago

I hadn't seen that error, it was from a more recent Nim version than when I found the original problem, but you're right, it's there now so just as well it's fixed! Thank you for your help, all merged now.