search

zqqw / pakku

Pacman wrapper with AUR support
GNU General Public License v3.0
39 stars 3 forks source link

Adding `pinned` badge to pinned comments #23

Closed hochata closed 2 years ago

hochata commented 2 years ago

I added a badge to indicated when a comment is in the pinned section. This is because a pinned comment apears twice, once in the Pinned section and in the regular section. The badge allows to diferentiate its ocurrences.

To do this, the parsing of the comments was split into each section and a pinned attribute was added to the comment tuple.

hochata commented 2 years ago

By the way, could some one update the Plans section on the Wiki? I don't know enough about its limitations to decide what would be nice to have. I guess it would also be useful to port some issues from kitsunyan's repo to have a unified todo list for Pakku.

zqqw commented 2 years ago

Certainly, you should also be able to make commits yourself now as a contributor, test them first for a bit to try and ensure there are no unexpected side effects though!

I'm not sure how many of those old issues apply now, I'd personally look at them for ideas for improvement if they can still be reproduced, but deal with things here as they arise. As the last possibly relevant ones date from 3 years ago it's pretty much necro-posting, quite likely many of those people switched to using something else.

hochata commented 2 years ago

Sure, if you prefer I could commit directly. I just used a pull request to have some form of feedback. An extra opinion is always welcomed.

And yeah, most issues there are pretty old. But I guess at least the feature requests could be an inspiration. By the comments, it seem kitsunyan had several ideas that were never implemented.

zqqw commented 2 years ago

Thank you for the courtesy, but I have faith in your good judgement. The plans page was mainly to list known issues to watch out for, also to give some idea what I might try and get working in future, but I haven't got through that list yet! Also it was easier than opening lots of issues for small bugs, or for longer term goals that could take a while before they even get looked at. It would be fine to open issues for things which don't work or features you would like to add, especially if you wanted to look at something yourself and discuss it or provide progress updates. Originally I was trying to find an AUR helper that could also build binary packages on Artix following a discussion there then Pakku which was closest to doing that stopped working, so I said to myself well darn it I'll have to fix Pakku first, the pakku-git PKGBUILD was redirected to my repo by the maintainer as it worked and it went from there. Also I'd never heard of Nim before encountering Pakku so it took a while to catch up before finally getting time to fix the binary builds. Anyway if you have some ideas then by and large go for it, it's fine, I've just been doing what I could to get Pakku working nicely. I like this comment from an old issue no. 25: "I think your helper has the potential to become the best out here" so that's something to try and live up to!

hochata commented 2 years ago

Well, I started using Pakku because I like Nim (I was using Paru, but I hate Rust compile times). And I have been using Artix for several months now, and I didn't even realized that is was problematic for AUR wrappers, so I would say your effort is very appreciated :)

I was just looking around on the Pakku repo a few weeks ago when I notices that you may need help. So far I don't have any complains about Pakku, so I don't really have suggestions about what to improve.

But I would like to help however I can. So I guess I will just try to implement or fix the Plan list for the moment.

Thank you very much for all your effort!

zqqw commented 2 years ago

Yes, it works well and I've been using it all this time very happily. It was specifically the -Sn (and related -Sz) options with customizepkg (which Yay has, and now Paru too) which only Yaourtix could do on Artix, those are important for people who need to use a modified version of a binary repo package. No other aur helper I know of can rebuild binary packages even in Arch, there's an issue on Yay where jguer says it would be fine if anyone wanted to implement it, so it was either fix Pakku or write that entire section in Go (which I don't know either) to achieve that. Luckily I found Nim an easy language to learn and work with. We should probably try to let each other know what we are working on to avoid duplication, currently I'm still looking at how if you define "TmpDir = /tmp/dir1/dir2" in /etc/pakku.conf dir1 is not deleted later although I haven't had much time lately, and it's a bit of an obscure and minor bug really.