search

zquestz / omniauth-google-oauth2

Oauth2 strategy for Google
1.46k stars 414 forks source link

img_url is broken #359

Closed kuncha20 closed 3 years ago

kuncha20 commented 5 years ago

Some of the img_url's being returned give 404 error. example, https://lh5.googleusercontent.com/-jRbSSv1i5u4/AAAAAAAAAAI/AAAAAAAADa4/xjWv4J3ywnk/s50/s50-c/photo.jpg. The pattern I could find is any url which has /s50-c appended after /s50 appears to be broken. Fetching the img_url from omniauth_hash's info["image"] field.

4ndv commented 5 years ago

Maybe related to #329, try to remove "/s50/" from the url

kuncha20 commented 5 years ago

Looks like its the same issue as #329 , Never realised this was a previously existing issue, is there any way to fix this issue from the gem side and not monkey-patching it.

karthickbabuos commented 5 years ago

Image URl construction on image_params method is causing the problem. Can be resolved through strategy.

zquestz commented 5 years ago

Would definitely love a PR to fix this if possible.