search

zquestz / omniauth-google-oauth2

Oauth2 strategy for Google
1.45k stars 414 forks source link

ruby-jwt removed support for `iat_leeway` #366

Closed venables closed 5 years ago

venables commented 5 years ago

I noticed I was getting InvalidIatErrors (as solved by this issue: https://github.com/zquestz/omniauth-google-oauth2/issues/197).

The documentation makes reference to leeway in the JWT library as a means to solve this, but, as of v 2.2.0 of the JWT library, iat leeway was removed: https://github.com/jwt/ruby-jwt/commit/8384f0cbd163a094a39b25c6f1eaaa625e08c9b8

Confirmed that locking the gem jwt to version 2.1.0 re-adds support for leeway and things are working smoothly.

zquestz commented 5 years ago

Thanks for the report. Would love if you put up a PR to add this to the README so people have a workaround.

zquestz commented 5 years ago

Actually did this myself. Thanks for the report!