Add a search provider for postgresql organization site

zquestz / s

Open a web search in your terminal.

MIT License

2.34k stars 114 forks source link

Add a search provider for postgresql organization site #107

Closed justdoit0823 closed 8 years ago

justdoit0823 commented 8 years ago

It's a convenient way to search postgresql document with this.

zquestz commented 8 years ago

This PR has a number of issues.

The import path is not correct for the new provider.
Commits require squashing.
Travis changes should not be included.
.gitignore change should not be included.

justdoit0823 commented 8 years ago

As the above said, if i can't do this pull request, how can i make the binary program works fine.Travis test on go version 1.4.3 can't pass, the go get vet command will failed.The .gitignore file changed content only excludes emacs backup file.

zquestz commented 8 years ago

Unfortunately due to how go handles imports, there is no way for your local test to pass and the import to be defined correctly for your new provider. You need to make sure you reference where the file will be once the PR is accepted.

zquestz commented 8 years ago

I went ahead and added this provider and did the fixes. Thank you for your contribution. I am sure our users will like the postgresql documentation search. =)

justdoit0823 commented 8 years ago

Thank you for crorecting my mistakes, i should be more careful.