New provider: search for shell commands explained

zquestz / s

Open a web search in your terminal.

MIT License

2.34k stars 114 forks source link

New provider: search for shell commands explained #122

Closed xav-b closed 7 years ago

xav-b commented 7 years ago

Hi there,

Quick but hopefully not so dirty PR to add explainshell. I think I checked all the requirements of CONTRIBUTING.md but I'm not super familiar with OSS contribution so let me know ;)

I was planning to add Regex101 and may be Urban dictionnary since it's so easy.

zquestz commented 7 years ago

Thanks for the submission! These sites look like a good fit, just a few minor changes required before merge.

xav-b commented 7 years ago

Hi @zquestz thanks for the review !

Except for the comment above I updated the code so it's ready to push as soon as I have your answer for the Makefile.

zquestz commented 7 years ago

This looks great, if you don't mind squashing the commits that would be fantastic. Then I will happily merge. =)

xav-b commented 7 years ago

Sorry about the micro-mistakes... Does the git history looks good ?

zquestz commented 7 years ago

Perfecto @hackliff. Thank you for taking the time to submit a PR and work with me on modifications!