search

zquestz / s

Open a web search in your terminal.
MIT License
2.32k stars 114 forks source link

Homebrew #139

Closed chrisfinazzo closed 5 years ago

chrisfinazzo commented 5 years ago

The automated process for updating Homebrew formulas (brew bump-formula-pr) fails during its audit phase for v0.5.14. Specifically, the use of go_resource is now deprecated. Per the error below, is it possible to implement Go vendoring so that we can pull the latest version automatically?

screen shot 2018-12-22 at 10 33 57 pm
zquestz commented 5 years ago

We can definitely switch to go vendoring. Right now I do like gvt but am open to a PR to change the dependencies. I am pretty sure brew does have hooks to support gvt but not sure exactly how that works.

chrisfinazzo commented 5 years ago

I gave this another shot and (per your suggestion) used gvt. However, although I can see the dependencies in /vendor, Git currently ignores this file. I presume this should be removed from it and then commited.

In general this seems contradictory to gvt's own documentation which advocates not putting vendored source under versioning, but as I'm not that familiar with Go workflows, I'm a bit lost.

screen shot 2019-01-18 at 10 26 32 am
zquestz commented 5 years ago

There is no source checked into vendor, just the manifest which is exactly how gvt should work.

zquestz commented 5 years ago

Looks like 0.5.14 is now available on Homebrew. Closing.