fixes for fish completion

[ajm188]

• can just embed s -l as the options
• fix condition function so it doesn't double-trigger

@bucaran, any idea why i couldn't combine the conditions on 7 and 8 with -a?

[zquestz]

Going to wait for @bucaran to take a look. Thanks for looking into this!

[ajm188]

No problem! It drives me crazy when things don't work the way i expect them to

[ghost]

@owners Hey dudes. TBH if s was my own utility, I would use a simpler method like the one proposed earlier using only fish builtins. It would not be 100% perfect, but it's also a no-brainer and easier to maintain in the long run. @zquestz mentioned he does not use fish, so I wonder, who's going to maintain this code?

Sorry for being too preachy :sweat_smile:, but I guess that's one oddity that comes with age. In general, the PR looks alright and if @ajm188 is reporting good results then go for it.

[ajm188]

@bucaran yeah, that makes sense. However, I would argue a few counter-points.

• First, very few people actually use fish, so if this ever were to break, not too many people would be impacted.
• Second, of the very small percentage of people that are affected, I'd suspect that many would be able (and willing) to fix it.

Even though I could say "I'm always available, just mention me on the PR!", with the best intentions, we all know how that can become not true over time, so I'm making these arguments assuming that I'm not around to dig into a problem.

[ghost]

You made some good counter-points. Worst case scenario, @zquestz can ping any of us, and chances are we might just be available :smile:

[zquestz]

Yeah was just using this and some of the behavior is not ideal, but none of it totally breaks it either. In an ideal world I would want:

• - p, --provider to autocomplete the provider list.
• -c, --cert to use file path completion.to a .pem file
• -k, --key use file path completion to .pem file
• All flags to show up when tabbing -

Anything else would do nothing on tab, making sure auto complete never fires by accident for someone typing a search.

[ajm188]

@zquestz that can definitely be done. I'll try to get a PR in sometime soon

[ajm188]

@zquestz should --binary complete to anything in $PATH?

also, if I have more questions, should I just put them here, or open an issue and keep the discussion contained there?

[zquestz]

--binary should also be a full path.

[ajm188]

Yeah, but it should be looking for any binaries that are in $PATH right?

So, for example, if PATH=/usr/bin:/usr/local/bin then if I type "foo", it should look for "/usr/bin/foo" and "/usr/local/bin/foo", but prefer the higher up part of the $PATH if it finds one. That seems like the correct behavior to me, but if you think otherwise, I'd rather hear it before I implement it :smile:

[zquestz]

I would just have it do normal autocompletion of directories and files (executable only if possible). Don't need to get fancy and look through the path.