zrashwani / arachnid

Crawl all unique internal links found on a given website, and extract SEO related information - supports javascript based sites
MIT License
253 stars 60 forks source link

The use of `$this` inside closures #3

Closed onema closed 9 years ago

onema commented 9 years ago

Your package supports php version 5.3, but there are several lines with in closures that use $this yet $this can not be used in anonymous functions before php version 5.4.

https://github.com/codeguy/arachnid/blob/master/src/Arachnid/Crawler.php#L181 https://github.com/codeguy/arachnid/blob/master/src/Arachnid/Crawler.php#L193 https://github.com/codeguy/arachnid/blob/master/src/Arachnid/Crawler.php#L200 https://github.com/codeguy/arachnid/blob/master/src/Arachnid/Crawler.php#L235

A simple solution would be to required version 5.4. This would also have a nice side effect as it would use the latest version of goute.