search

zreptil / nightscout-reporter

a web app to create PDF documents from nightscout data
https://nightscout-reporter.zreptil.de/
BSD 3-Clause "New" or "Revised" License
59 stars 47 forks source link

Bug: Daily Graph - CGP - Pentagon - CV% is set to the average for the whole period #32

Closed cfaagaard closed 4 years ago

cfaagaard commented 4 years ago

The CV% in the pentagon on the "daily graph"-page is showing the average for the whole period, not the daily CV% as shown correct int "Daily Statistics"-page.

Example: Running a report for November. On the 11/02/2019 the CV% value in the "Daily statics" is 32.9, but on the "Daily Graph" the value is 50%. Which is incorrect. This should be 32.9 as well. In fact, for all the dates in the "Daily Graph"-pages the CV% is 50%. And the average CV% for the whole period is 50% as shown in the "Daily Statics". image image

steve8x8 commented 4 years ago

Ah, something similar seems to happen with the avg BG (#33)...

zreptil commented 4 years ago

Good information. Thank you for finding this bug :) It will be fixed in Version 1.3.8

cfaagaard commented 4 years ago

testing version 1.3.8: the pentagon graph is still showing the wrong value. The text shows 61% (which is correct) but the graph is showing the average for the periode 42%.

image

cfaagaard commented 4 years ago

Same thing (I think) with the ToR. It shows the whole periods value 516 minutes, it is not showing the total of minutes for this day. Both in graph and text. image

zreptil commented 4 years ago

Great findings, thank you. :) It will be fixed in Version 1.3.9.

cfaagaard commented 4 years ago

And thank you for a great tool. I have been promoting your tool in the Danish Loop community, so expect some more Danish users :-)

zreptil commented 4 years ago

I am glad to hear this :) If you need danish language in Nightscout Reporter let me know. I will add this language then to crowdin. But first i need to know if it is better to have english or german as baselanguage for the translators.

cfaagaard commented 4 years ago

I prefer the English version. :-) But I will let you know if there is a need for a Danish translation. Thank you.