zreptil / nightscout-reporter

a web app to create PDF documents from nightscout data
https://nightscout-reporter.zreptil.de/
BSD 3-Clause "New" or "Revised" License
59 stars 47 forks source link

Download buttons not separated #68

Closed hannesvoss closed 1 year ago

hannesvoss commented 1 year ago

Hello there,

I do have an issue with the displayed download buttons. Whenever I hit the first of two buttons, both display as 'clicked' and the download for the second part starts. I tested it on both the normal and the beta version of the reporter. It happens on Firefox (Version 107.0) and Chrome (Version 107.0.5304.110).

Do you have an idea where the bug originates from? I did not have that issue the last time I was using it (around 3 months ago).

Best, Hannes

zreptil commented 1 year ago

Hi Hannes,

up to now, I don't know anything about this. First of all: what buttons do you mean? The Buttons when a pdf is split in multiple downloads? At my system they work as intended. Could you provide me with the settings of your system, so that i can reproduce this issue on my system? Either as screenshots from the settings and the output parameters or export from the settings. Then I can see, if this error is reproducable at my site.

hannesvoss commented 1 year ago

Hi there, I recorded a small GIF for you to show what I mean. I also attached my settings (without private data).

bug Screenshot 2022-11-24 at 20-33-37 Nightscout Reporter Screenshot 2022-11-24 at 20-57-53 Nightscout Reporter

zreptil commented 1 year ago

Hi Hannes,

thanks for the demonstration. I was able to reproduce the error. The reason for the error is that you have selected to open the pdf in the same window. This is needed on smartphones, but not very useful when working in a browser. If you don't select this option in the Output parameters, then the buttons will work independent. At least they do it in my environment. I think, i will remove this option, when releasing the next version that will be based on angular without dart.

I hope it also works for you.

kind regards Andi

hannesvoss commented 1 year ago

Hi Andi,

thanks for your quick response! It works for me too now, so I'll close the issue :)

Best, Hannes