search

zrlio / disni

DiSNI: Direct Storage and Networking Interface
Apache License 2.0
186 stars 66 forks source link

PingPong test with TCP vs RDMA modes. #29

Closed petro-rudenko closed 6 years ago

petro-rudenko commented 6 years ago

PingPong test inspiried by RDMA perftest ib_send_lat with 2 modes: RDMA, TCP. Parameters the same as in SendRecv benchmark tests, with new additional argument: -m rdma|tcp.

CC @yuvaldeg

patrickstuedi commented 6 years ago

Thinking about this a bit more.. What if we do the following? We keep the original version of the code, but rename the classes PingPong.. to something like RDMAvsTcpBenchmark and also change the default setting in the client so that it runs both the RDMA and the TCP version and prints out the performance for both. What do you think?

petro-rudenko commented 6 years ago

@patrickstuedi i've reverted back to add TCP case for SendRecv benchmark test. So should we return back to have separate class for this?

patrickstuedi commented 6 years ago

Just revert it back to the original PR with the PingPong benchmark that also has the TCP benchmark in it, but please rename the class, and also make sure it runs both tcp and rdma by default.

petro-rudenko commented 6 years ago

OK

petro-rudenko commented 6 years ago

Done