search

zrlio / disni

DiSNI: Direct Storage and Networking Interface
Apache License 2.0
186 stars 66 forks source link

JNI library build system updates #9

Closed patrickmacarthur closed 7 years ago

patrickmacarthur commented 7 years ago

This PR contains a number of modernizations to the autotools configuration for libdisni, along with a single fix to select the correct include directory when using a system-installed DPDK (i.e., from the Ubuntu packages).

Note that this PR also sets the package version in libdisni/configure.ac and this should be updated with each subsequent release along with the version in pom.xml.

These changes have been tested on my Ubuntu 17.04 system against the system-installed DPDK 16.11.1 and my own compiled SPDK 17.03.

patrickstuedi commented 7 years ago

Hey Patrick, this looks very good at a first glance, thanks, I'm going to have a more detailed look with my colleagues later this week..

PepperJo commented 7 years ago

Lgtm. Only one comment on the README file. We also have people using this on POWER so either we include both paths (x86 and ppc) for DPDK or we leave it as is.

patrickmacarthur commented 7 years ago

Fixed; the instructions now use a placeholder and mention both possibilities.