Closed ZiYang-oyxy closed 6 years ago
Changes look good to me.
The commit is missing a sign-off; can you amend the commit adding a sign-off indicating that you agree to the Developer Certificate of Origin; then just force-push the updated commit to your branch? Once you do that @PepperJo can merge this PR.
Example:
Signed-off-by: Full Name <email@domain.com>
done @PepperJo
ZiYang-oyxy
commented
6 years ago
Changes look good to me.
The commit is missing a sign-off; can you amend the commit adding a sign-off indicating that you agree to the Developer Certificate of Origin; then just force-push the updated commit to your branch? Once you do that @PepperJo can merge this PR.
Example: