search

zrnsm / pyculiarity

A Python port of Twitter's AnomalyDetection R Package
GNU General Public License v3.0
365 stars 146 forks source link

rpy2 #28

Open wmpauli opened 6 years ago

wmpauli commented 6 years ago

Hi!

Thank for creating this python port. I noticed that the readme file states that this package depends on rpy2, but it appears to me that it no longer does, since you are now using the rstl port of R's stl function. Or is there another place where rpy2 is needed that I didn't notice?

Thanks again!

zrnsm commented 6 years ago

Hi Wolfgang,

You're correct. The dependency on rpy2 should be gone now. The readme just needs to be updated accordingly.

On Thu, Oct 4, 2018, 5:48 PM Wolfgang Pauli notifications@github.com wrote:

Hi!

Thank for creating this python port. I noticed that the readme file states that this package depends on rpy2, but it appears to me that it no longer does, since you are now using the rstl port of R's stl function. Or is there another place where rpy2 is needed that I didn't notice?

Thanks again!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nicolasmiller/pyculiarity/issues/28, or mute the thread https://github.com/notifications/unsubscribe-auth/ABLrz9t4AN3sDvtWrEbix-kn6MMRVJiUks5uhqxqgaJpZM4XJX6u .

wmpauli commented 6 years ago

Excellent! Thanks.