search

zs-zs / grunt-selenium-standalone

Grunt tasks for running a standalone Selenium server using the popular selenium-standalone package
MIT License
8 stars 9 forks source link

Fix options configuration for latest version of selenium-standalone #3

Closed JSMike closed 8 years ago

JSMike commented 8 years ago

Also adds option to add stopOnExit config to the grunt-selenium-standalone task, this will kill the selenium process if grunt fails before you stop selenium.

Example config:

{
    selenium_standalone: {
        server: {
            stopOnExit: true,
            seleniumVersion: '2.47.0',
            seleniumDownloadURL: 'http://selenium-release.storage.googleapis.com',
            drivers: {
                chrome: {
                    version: '2.20',
                    arch: process.arch,
                    baseURL: 'http://chromedriver.storage.googleapis.com'
                }
            }
        }
    }
}

To use this version now, while the repo owner is MIA, update your package.json entry for grunt-selenium-standalone to match:

    "grunt-selenium-standalone": "git+https://github.com/JSMike/grunt-selenium-standalone.git#v0.1.5"
JSMike commented 8 years ago

@zs-zs I see you were active again last week. Could you please look at this PR?

JamesMGreene commented 8 years ago

:+1:

JamesMGreene commented 8 years ago

@JSMike: Heads up: I'm going to start picking your master branch apart and merging/editing each of the changes you've generously offered up but rest assured that it will all make its way into the mainline now. 💝

JamesMGreene commented 8 years ago

@JSMike I already merged your first 2 commits with corrected formatting but I'd like to propose something different for your 3rd commit. I'll submit a PR tonight.

JamesMGreene commented 8 years ago

@JSMike Your third commit was addressed via 290f6e0ca58583bcb3c21715f5e0d22699972eac

Updated, versioned, released, and published as v1.0.0.

JamesMGreene commented 8 years ago

Sorry, had to release a quick patch fix: v1.0.1 :confused:

JSMike commented 8 years ago

Thank you, I was overly busy this weekend. If you want me to review anything just tag me