search

zs-zs / grunt-selenium-standalone

Grunt tasks for running a standalone Selenium server using the popular selenium-standalone package
MIT License
8 stars 9 forks source link

Add option to stop a running selenium-standalone server when grunt exits #4

Closed JSMike closed 8 years ago

JSMike commented 8 years ago

If a task in grunt fails in between selenium_standalone:target:start and selenium_standalone:target:stop, causing grunt to exit before the stop call, the selenium_standalone server process was never being stopped. This PR adds a flag to handle process.on('exit' to make sure a running task is stopped. Also placed a conditional around the stop to make sure the kill function wasn't called if it didn't exist.

JSMike commented 8 years ago

included these changes in my other PR, closing.