search

zsa / reactor

Reactor is the firmware generator part of Fusion
MIT License
58 stars 28 forks source link

Preonic doesn't seem to use keymaps folder, probably need to indicate a folder per type #1

Closed tdegrunt closed 8 years ago

ezuk commented 8 years ago

actually, IMHO we can enforce a folder hierarchy. To me that would be the logical thing to do -- convention over configuration, so to speak. Keyboards can conform to the structure as needed. Just my opinion. :)

On 31 October 2015 at 11:16, Tom de Grunt notifications@github.com wrote:

— Reply to this email directly or view it on GitHub https://github.com/ErgoDox-EZ/reactor/issues/1.

tdegrunt commented 8 years ago

@jackhumbert Is there any reason preonic's keymaps are stored in extended_keymaps?

jackhumbert commented 8 years ago

Sorry - that project hasn't been updated entirely! The whole Preonic project should be similar to the Planck's.

tdegrunt commented 8 years ago

@jackhumbert Want me to open an issue on qmk for this?

jackhumbert commented 8 years ago

Nah, but it should definitely follow the same form as the Planck - it'll get changed over once we start getting Preonic PCBs in.

On Mon, Jan 4, 2016 at 9:54 AM, Tom de Grunt notifications@github.com wrote:

@jackhumbert https://github.com/jackhumbert Want me to open an issue on qmk for this?

— Reply to this email directly or view it on GitHub https://github.com/ErgoDox-EZ/reactor/issues/1#issuecomment-168697489.

tdegrunt commented 8 years ago

Allright, thanks. Closing this.