Closed mattgenious closed 4 years ago
Nice! @zsajjad can we merge this?
Can this please be merged? @zsajjad
Thanks for the updates @mattgenious. I made a small change in a separate pull request which is somewhat related to your Typescript maintenance https://github.com/zsajjad/react-facebook-pixel/pull/27
Hopefully they're both merged in the near future.
@Joeao ah I see, I missed that one 😄 yeah, lets hope they're merged soon 😁
@zsajjad is this going to be merged any time soon?
Any news on this? Perhaps owner should invite more collaborators.
No news, I agree 😁
Has anyone tested it? I don't have enough time to test it and library doesn't have any tests :(
I have merged it by not publishing it until tested.
I will test it tomorrow, I have my own pull request running on a production system without problems, but I will clone the original repo with all changes and see if everything works or not.
Sounds good, let me know when you have tested it. I will release alpha soon and will test my self as well!
I have updated dependencies and also bumped new version hope this helps.
Hey @zsajjad I have tested and added some changes to the type definition that I will submit in a pull request that makes the types better correspond with the declared types from facebooks documentation here https://developers.facebook.com/docs/facebook-pixel/reference/#object-properties Everything works for me with the changed types.
Also my apologies for the delay I got sick the day after 😬
This adds jasondecastros support for tracking with multiple different pixel initialized as well as typescript typing for it.