search

zsajjad / react-facebook-pixel

React JS wrapper for Facebook's Pixel
MIT License
233 stars 86 forks source link

Update AdvancedMatching type to include external_id #59

Open coleby opened 4 years ago

coleby commented 4 years ago

Super minimal change but external_id is a valid option on the facebook pixel docs and it's missing from the AdvancedMatching type. Instead of overriding the type on my end, I figured I'd add it incase anyone else needs it!

coleby commented 4 years ago

@zsajjad mind taking a look? 🙇

JStonevalley commented 3 years ago

@zsajjad mind taking a look? 🙇

Hi is there any possibility this is merged any time soon? :)

wootwoot1234 commented 3 years ago

Please merge this! :)

jgarciablockbar commented 1 year ago

wondering why it hasn't been merged 😝

thanks for the tip @coleby for now I'm doing:

interface IOverrideAdvancedMatching extends AdvancedMatching {
  external_id: string;
}