search

zsawyer / MumbleLink

Minecraft + Mumble + MumbleLink = You hear where voices come from and how far away they are! This is a Minecraft mod based on "Minecraft Forge". It's purpose is to be able to use Minecraft in conjunction with Mumble's positional audio feature (http://mumble.sourceforge.net/).
http://www.minecraftforum.net/topic/217587-
GNU Lesser General Public License v3.0
109 stars 24 forks source link

Properly register the extension for display test #29

Closed 3TUSK closed 4 years ago

3TUSK commented 4 years ago

Under the Forge framework, ExtensionPoint.DISPLAYTEST is used during server handshaking period. The result of this test will determine "whether forge will display a green check mark, indicating compatibility", as shown below (before this PR):

2020-05-22_18 11 26

Do note that this display does not stop you from joining the server; it is only a bit misleading to average users. After this PR, Forge should give you a green check mark instead.

(I'd like to help cleaning up the codebase as well. However, I would like to make that a separate PR for that one.)

Ref: https://mcforge.readthedocs.io/en/1.14.x/concepts/sides/#writing-one-sided-mods

zsawyer commented 4 years ago

Thank you for your efforts. It is much much appreciated.

zsawyer commented 4 years ago

Feel free to do said cleanup. I am sure there are things to improve.