zsawyer / MumbleLink

Minecraft + Mumble + MumbleLink = You hear where voices come from and how far away they are! This is a Minecraft mod based on "Minecraft Forge". It's purpose is to be able to use Minecraft in conjunction with Mumble's positional audio feature (http://mumble.sourceforge.net/).
http://www.minecraftforum.net/topic/217587-
GNU Lesser General Public License v3.0
109 stars 24 forks source link

Naive 1.16.3+ port #32

Closed dantaeusb closed 3 years ago

dantaeusb commented 3 years ago

Changed some class/method signatures to work on 1.16.3. Implementation was tested on my own Minecraft 1.16.4 and Mumble (MurMur) server, no issues found so far.

Something may have to be changed here but I guess it's a good place to start.

Should solve #31

zsawyer commented 3 years ago

Hello and thank you for your valuable contribution. I am still checking. This looks really good. Sometimes it's just that simple.

PS: I think Vec3D has been renamed 4 times now during this project.

GoBoopADog commented 3 years ago

I've been trying to compile this PR myself but haven't been able to figure out how to as I've never tried compiling my own mods before. Please accept the PR so I (And many others) can use it :)

dantaeusb commented 3 years ago

@GoBoopADog you can use the one I've built for myself in meantime https://www.icloud.com/iclouddrive/0pE5IqPiggqIGFFljUV8CX9XA#mumblelink-1.16.3-4.5.1 . Don't forget to enable the position tracking in mumble settings.

Wearfoi commented 3 years ago

@GoBoopADog you can use the one I've built for myself in meantime https://www.icloud.com/iclouddrive/0pE5IqPiggqIGFFljUV8CX9XA#mumblelink-1.16.3-4.5.1 . Don't forget to enable the position tracking in mumble settings.

I'm having a problem with this mod. I've downloaded it to my mods folder on version 1.16.3 but Minecraft tells me I need javafml:35. How do I fix this?

dantaeusb commented 3 years ago

I'm having a problem with this mod. I've downloaded it to my mods folder on version 1.16.3 but Minecraft tells me I need javafml:35. How do I fix this?

Sorry, I've added an extra version dependedncy and didn't build/check that for 1.16.3, even though it possible with fixing line above. Try to use Minecraft 1.16.4 with Forge 35 if you can, or build this mod with fixed Forge dependency in comment above.

Wearfoi commented 3 years ago

I'm having a problem with this mod. I've downloaded it to my mods folder on version 1.16.3 but Minecraft tells me I need javafml:35. How do I fix this?

Sorry, I've added an extra version dependedncy and didn't build/check that for 1.16.3, even though it possible with fixing line above. Try to use Minecraft 1.16.4 with Forge 35 if you can, or build this mod with fixed Forge dependency in comment above.

I dont know much about coding sorry, do you have an older build suited for 1.16.3?

aybri commented 3 years ago

Will the .jar from iCloud work with 1.16.5?

aybri commented 3 years ago

Nevermind, it does.

hackerstudios commented 3 years ago

@GoBoopADog you can use the one I've built for myself in meantime https://www.icloud.com/iclouddrive/0pE5IqPiggqIGFFljUV8CX9XA#mumblelink-1.16.3-4.5.1 . Don't forget to enable the position tracking in mumble settings.

please send something else other than apple APPLE SUCKS THEY LOCKED MY ACCOUNT send something downloadable for everyone without having to make an apple account

dantaeusb commented 3 years ago

please send something else other than apple APPLE SUCKS THEY LOCKED MY ACCOUNT send something downloadable for everyone without having to make an apple account

Haha, those *** managed to vendor-lock cloud storage, omg. It was accessible with incogtito before, now it asks for Apple ID :)

Here's same jar in Google Drive @hackerstudios: https://drive.google.com/file/d/1C-Lc_noZK64m8KJ53nDiY20V3_MZCqQt/view?usp=sharing

zsawyer commented 3 years ago

Thanks again for the PR - though this will not be merged directly this helped me massively for creating the 1.16.x releases.