search

zsawyer / MumbleLink

Minecraft + Mumble + MumbleLink = You hear where voices come from and how far away they are! This is a Minecraft mod based on "Minecraft Forge". It's purpose is to be able to use Minecraft in conjunction with Mumble's positional audio feature (http://mumble.sourceforge.net/).
http://www.minecraftforum.net/topic/217587-
GNU Lesser General Public License v3.0
109 stars 24 forks source link

TeamSpeak context compat issue #60

Open magneticflux- opened 2 years ago

magneticflux- commented 2 years ago

I found this TeamSpeak issue with the context field here: https://github.com/magneticflux-/fabric-mumblelink-mod/issues/79

Remember to include this change for Minecraft 1.19 and later instead of sending an empty context: https://github.com/magneticflux-/fabric-mumblelink-mod/commit/540d29a3350fffd5fd20a5711ff514aae34369d2

zsawyer commented 1 year ago

This would effect this code https://github.com/zsawyer/MumbleLink/blob/9e2a8db41ed1a49977540f24f343df23cc95d656/mod/src/main/java/zsawyer/mods/mumblelink/mumble/UpdateData.java#L195

or the addon could be extended: https://github.com/zsawyer/MumbleLink/blob/QnD-MC_JNA/mod/src/main/java/zsawyer/mods/mumblelink/addons/pa/es/ExtendedPASupport.java#L60

However we explicitly did set this to empty at some point. // empty context because the plugin name is already always prepended anyways

I am not happy with this arbitrariness imposed by TeamSpeak.

zsawyer commented 10 months ago

Note: hardcode context to be "Context" starting with 1.19.x