search

zscaler / terraform-provider-zia

:cloud: Terraform Provider for Zscaler Internet Access :cloud:
MIT License
37 stars 5 forks source link

fix: Implemented IPv4 address validation for dest_address in the resource zia_firewall_filtering_rule #368

Closed willguibr closed 2 months ago

willguibr commented 2 months ago

fix: Implemented IPv4 address validation for dest_address in the resource zia_firewall_filtering_rule

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 68.38%. Comparing base (986dbb2) to head (b322416). Report is 1 commits behind head on master.

Files Patch % Lines
zia/validator.go 0.00% 30 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/zscaler/terraform-provider-zia/pull/368/graphs/tree.svg?width=650&height=150&src=pr&token=A9J4AJS7F5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zscaler)](https://app.codecov.io/gh/zscaler/terraform-provider-zia/pull/368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zscaler) ```diff @@ Coverage Diff @@ ## master #368 +/- ## ========================================== - Coverage 68.51% 68.38% -0.14% ========================================== Files 82 82 Lines 13835 13865 +30 ========================================== + Hits 9479 9481 +2 - Misses 3763 3792 +29 + Partials 593 592 -1 ``` | [Files](https://app.codecov.io/gh/zscaler/terraform-provider-zia/pull/368?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zscaler) | Coverage Δ | | |---|---|---| | [zia/resource\_zia\_cloud\_app\_control\_rules.go](https://app.codecov.io/gh/zscaler/terraform-provider-zia/pull/368?src=pr&el=tree&filepath=zia%2Fresource_zia_cloud_app_control_rules.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zscaler#diff-emlhL3Jlc291cmNlX3ppYV9jbG91ZF9hcHBfY29udHJvbF9ydWxlcy5nbw==) | `3.63% <ø> (ø)` | | | [zia/resource\_zia\_firewall\_filtering\_rules.go](https://app.codecov.io/gh/zscaler/terraform-provider-zia/pull/368?src=pr&el=tree&filepath=zia%2Fresource_zia_firewall_filtering_rules.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zscaler#diff-emlhL3Jlc291cmNlX3ppYV9maXJld2FsbF9maWx0ZXJpbmdfcnVsZXMuZ28=) | `3.85% <ø> (ø)` | | | [zia/validator.go](https://app.codecov.io/gh/zscaler/terraform-provider-zia/pull/368?src=pr&el=tree&filepath=zia%2Fvalidator.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zscaler#diff-emlhL3ZhbGlkYXRvci5nbw==) | `18.06% <0.00%> (-1.50%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/zscaler/terraform-provider-zia/pull/368/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zscaler)