zscaler / terraform-provider-zia

:cloud: Terraform Provider for Zscaler Internet Access :cloud:
MIT License
37 stars 5 forks source link

Fix: Added Sleep/Retry on Forward Control Rule resource #373

Closed willguibr closed 3 weeks ago

willguibr commented 3 weeks ago

Provide a general summary of your changes in the title above. You should remove this overview, any sections and any section descriptions you don't need below before submitting. There isn't a strict requirement to use this template if you can structure your description and still cover these points.

Description

Describe your changes in detail through motivation and context. Why is this change required? What problem does it solve? If it fixes an open issue, link to the issue using GitHub's closing issues keywords1.

Has your change been tested?

Explain how the change has been tested and what you ran to confirm your change affects other parts of the code. Automated tests are generally expected and changes without tests should explain why they aren't required.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

Checklist:

codecov-commenter commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 41.37931% with 17 lines in your changes missing coverage. Please review.

Project coverage is 72.09%. Comparing base (4b99400) to head (b633ba6).

Files with missing lines Patch % Lines
zia/resource_zia_forwarding_control_rule.go 41.37% 15 Missing and 2 partials :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/zscaler/terraform-provider-zia/pull/373/graphs/tree.svg?width=650&height=150&src=pr&token=A9J4AJS7F5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zscaler)](https://app.codecov.io/gh/zscaler/terraform-provider-zia/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zscaler) ```diff @@ Coverage Diff @@ ## master #373 +/- ## ========================================== + Coverage 68.57% 72.09% +3.52% ========================================== Files 82 82 Lines 13883 13910 +27 ========================================== + Hits 9520 10029 +509 + Misses 3770 3144 -626 - Partials 593 737 +144 ``` | [Files with missing lines](https://app.codecov.io/gh/zscaler/terraform-provider-zia/pull/373?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zscaler) | Coverage Δ | | |---|---|---| | [zia/resource\_zia\_forwarding\_control\_zpa\_gateway.go](https://app.codecov.io/gh/zscaler/terraform-provider-zia/pull/373?src=pr&el=tree&filepath=zia%2Fresource_zia_forwarding_control_zpa_gateway.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zscaler#diff-emlhL3Jlc291cmNlX3ppYV9mb3J3YXJkaW5nX2NvbnRyb2xfenBhX2dhdGV3YXkuZ28=) | `4.19% <ø> (ø)` | | | [zia/resource\_zia\_forwarding\_control\_rule.go](https://app.codecov.io/gh/zscaler/terraform-provider-zia/pull/373?src=pr&el=tree&filepath=zia%2Fresource_zia_forwarding_control_rule.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zscaler#diff-emlhL3Jlc291cmNlX3ppYV9mb3J3YXJkaW5nX2NvbnRyb2xfcnVsZS5nbw==) | `50.00% <41.37%> (+47.42%)` | :arrow_up: | ... and [18 files with indirect coverage changes](https://app.codecov.io/gh/zscaler/terraform-provider-zia/pull/373/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zscaler)