zscaler / zscaler-sdk-go

Zscaler SDK for Golang (ZPA/ZIA/ZDX/ZCC APIs)
https://zscaler.com
MIT License
10 stars 1 forks source link

feat: Added more integration tests improvements #247

Closed willguibr closed 4 months ago

willguibr commented 4 months ago

Provide a general summary of your changes in the title above. You should remove this overview, any sections and any section descriptions you don't need below before submitting. There isn't a strict requirement to use this template if you can structure your description and still cover these points.

Description

Describe your changes in detail through motivation and context. Why is this change required? What problem does it solve? If it fixes an open issue, link to the issue using GitHub's closing issues keywords1.

Has your change been tested?

Explain how the change has been tested and what you ran to confirm your change affects other parts of the code. Automated tests are generally expected and changes without tests should explain why they aren't required.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

Checklist:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 38.29787% with 87 lines in your changes are missing coverage. Please review.

Project coverage is 27.27%. Comparing base (3ae5801) to head (8e988f4). Report is 3 commits behind head on master.

Files Patch % Lines
zcc/services/remove_devices/zcc_remove_devices.go 0.00% 16 Missing :warning:
zcc/services/manage_pass/manage_pass.go 0.00% 15 Missing :warning:
zcc/services/secrets/getpasswords/getpasswords.go 0.00% 14 Missing :warning:
zcc/client.go 38.88% 9 Missing and 2 partials :warning:
...oning/public_cloud_account/public_cloud_account.go 60.00% 8 Missing and 2 partials :warning:
zcc/services/common/common.go 0.00% 6 Missing :warning:
zcc/services/downloaddevices/download_devices.go 57.14% 3 Missing and 3 partials :warning:
zcc/services/manage_pass/service.go 0.00% 2 Missing :warning:
zcc/services/remove_devices/service.go 0.00% 2 Missing :warning:
zcc/services/secrets/getotp/get_otp.go 83.33% 1 Missing and 1 partial :warning:
... and 2 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #247 +/- ## =========================================== - Coverage 47.77% 27.27% -20.50% =========================================== Files 251 61 -190 Lines 6439 1518 -4921 =========================================== - Hits 3076 414 -2662 + Misses 2960 1020 -1940 + Partials 403 84 -319 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.