zscaler / zscaler-sdk-go

Zscaler SDK for Golang (ZPA/ZIA/ZDX/ZCC APIs)
https://zscaler.com
MIT License
10 stars 1 forks source link

fix: Fixed subRules attribute in the ZIA package #251

Closed willguibr closed 3 months ago

willguibr commented 3 months ago

Provide a general summary of your changes in the title above. You should remove this overview, any sections and any section descriptions you don't need below before submitting. There isn't a strict requirement to use this template if you can structure your description and still cover these points.

Description

Describe your changes in detail through motivation and context. Why is this change required? What problem does it solve? If it fixes an open issue, link to the issue using GitHub's closing issues keywords1.

Has your change been tested?

Explain how the change has been tested and what you ran to confirm your change affects other parts of the code. Automated tests are generally expected and changes without tests should explain why they aren't required.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

Checklist:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 86.11111% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 51.44%. Comparing base (6a8f6e3) to head (c845eb7). Report is 1 commits behind head on master.

Files Patch % Lines
zia/services/devicegroups/devicegroups.go 85.71% 2 Missing and 1 partial :warning:
zia/services/adminuserrolemgmt/roles/adminroles.go 85.71% 1 Missing :warning:
...services/location/locationgroups/locationgroups.go 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #251 +/- ## ========================================== + Coverage 49.07% 51.44% +2.37% ========================================== Files 271 271 Lines 6780 6761 -19 ========================================== + Hits 3327 3478 +151 + Misses 3009 2820 -189 - Partials 444 463 +19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.