zschumacher / pydapper

a pure python port of the NuGet library dapper

https://pydapper.readthedocs.io/en/latest/

MIT License

64 stars 12 forks source link

Update dsnparse #298

Open Siliconrob opened 3 months ago

Siliconrob commented 3 months ago

297

Not sure if this is enough. I ran the tests and they are consistent between the changes, but if this needs further work send it back over to me.

@zschumacher

Siliconrob commented 2 months ago

Did this work? Sorry I got a bunch of emails and checking back on this

zschumacher commented 2 months ago

Did this work? Sorry I got a bunch of emails and checking back on this

Seems all of the tests failed lol. I'll take a look may be a problem with the action.

Siliconrob commented 2 months ago

First time I'm working with a poetry type project and I guess I messed up. I really tried to limit the change. I can try again tomorrow to see what I did wrong, but if you get to the issue or fix it please respond in here. I want to know how for the future

zschumacher commented 2 months ago

First time I'm working with a poetry type project and I guess I messed up. I really tried to limit the change. I can try again tomorrow to see what I did wrong, but if you get to the issue or fix it please respond in here. I want to know how for the future

no big deal @Siliconrob just run poetry lock --no-update

Siliconrob commented 2 months ago

Thanks for the tip. Poetry is kind of nice and more ordered than pip. I'm writing up a FastAPI using it and now I see how it works. For this though I can get back to this on the weekend if you are waiting on me.

Siliconrob commented 2 months ago

I did what you said @zschumacher . Is this better?

zschumacher commented 2 months ago

Running the tests now

Siliconrob commented 2 months ago

Ok got to dig into the test results to find what went wrong 🤔. Thanks